On 2013/09/12 08:35:04, ulan wrote:
LGTM if it is faster on benchmarks.
https://codereview.chromium.org/23684056/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/23684056/diff/1/src/ia32/lithium-ia32.cc#newcode1936
src/ia32/lithium-ia32.cc:1936: LOperand* temp = TempRegister();
Doesn't this increase register pressure?
Yes it does, it's a tradeoff, on the other hand the cpu does not have to
keep
the untagged value live.
since the untagD instruction usually occurs around other arithmetic
instructions, its a good assumption that the alu is saturated and it pays
off to
avoid the re-tagging. in other situations it will not pay off...
https://codereview.chromium.org/23684056/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
