LGTM if all comments are addressed and platform ports are done.
https://codereview.chromium.org/23477071/diff/1/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/23477071/diff/1/src/code-stubs.h#newcode755
src/code-stubs.h:755: void DispatchToCorrectArrayStub(MacroAssembler*
masm,
nit: s/DispatchToCorrectArrayStub/GenerateDispatchToArrayStub/
https://codereview.chromium.org/23477071/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/23477071/diff/1/src/hydrogen.cc#newcode1837
src/hydrogen.cc:1837: // if (FLAG_debug_code) {
As discussed offline: Let's move this diagnostic code into a separate
CL.
https://codereview.chromium.org/23477071/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/23477071/diff/1/src/ia32/code-stubs-ia32.cc#newcode7475
src/ia32/code-stubs-ia32.cc:7475: DispatchToCorrectArrayStub(masm,
DISABLE_ALLOCATION_SITES);
Move this dispatch to below the DONT_OVERRIDE dispatch, this completely
saves you from having the "switch_ready" label and jump.
https://codereview.chromium.org/23477071/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
