Reviewers: Yang,
Description:
Unify handling of position info in AST, part 1
* AstNode now has a position info.
* Removed various ad-hoc position infos from subclasses (most of which had
it).
* Position is always set with the constructor, instead of later.
* Take care to use kNoPosition in the right spots, to not crash the
debugger.
Still to do:
* Eliminate Conditional::then/else_position and
WhileStatement::condition_position.
* Make CaseClause a proper AstNode and eliminate its custom position.
* If possible, eliminate all uses of kNoPosition.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/24076007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+507, -468 lines):
M src/ast.h
M src/ast.cc
M src/full-codegen.cc
M src/parser.h
M src/parser.cc
M src/rewriter.cc
M src/scopes.cc
M test/cctest/test-ast.cc
M test/cctest/test-debug.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
