LGTM if comments are addressed.
For the record: I still don't like the idea of populating the code cache for
non-JSObject maps, but I don't have a better alternative.
https://codereview.chromium.org/23691056/diff/5001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23691056/diff/5001/src/objects.h#newcode1793
src/objects.h:1793: static void UpdateMapCodeCache(Handle<HeapObject>
object,
Please move this up a few lines to above the casting method. Also add a
short one-liner commment describing this method.
https://codereview.chromium.org/23691056/diff/5001/src/objects.h#newcode5495
src/objects.h:5495: inline bool is_jsobject_map();
I think starting to duplicate type checking predicates on Map is not
good (especially with a completely new naming convention). I would
rather have this predicate be inlined into CanInlinePropertyAccess
directly.
https://codereview.chromium.org/23691056/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
