https://codereview.chromium.org/23461039/diff/7001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/23461039/diff/7001/src/x64/macro-assembler-x64.cc#newcode824
src/x64/macro-assembler-x64.cc:824: bool restore_context =
restore_context_offset != 0;
Hmpf! The context is not restored when the offset is 0? That is not
exactly intuitive. Also I don't really understand why the CallIC for an
API function needs to restore the context of the callee at all. The
context should be restored by the caller IIUC.
So can't we just not restore Isolate::Context at all for API functions
and just always restore what's in the saved context slot?
https://codereview.chromium.org/23461039/diff/7001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/23461039/diff/7001/src/x64/stub-cache-x64.cc#newcode470
src/x64/stub-cache-x64.cc:470: __
movq(args.GetArgumentOperand(api_call_argc - 1), rdi);
Here $rdi does not yet contain the function to be called, value will be
off, $rdi must be loaded before.
https://codereview.chromium.org/23461039/diff/7001/src/x64/stub-cache-x64.cc#newcode480
src/x64/stub-cache-x64.cc:480: // Context save
nit: s/Context save/Save calling context./
https://codereview.chromium.org/23461039/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
