Revision: 16717
Author: [email protected]
Date: Fri Sep 13 12:49:57 2013 UTC
Log: line up crashing with chrome
[email protected]
BUG=
Review URL: https://codereview.chromium.org/23868025
http://code.google.com/p/v8/source/detail?r=16717
Modified:
/branches/bleeding_edge/src/flag-definitions.h
/branches/bleeding_edge/src/platform-posix.cc
/branches/bleeding_edge/src/platform-win32.cc
/branches/bleeding_edge/src/platform.h
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Thu Sep 12 13:50:38 2013
UTC
+++ /branches/bleeding_edge/src/flag-definitions.h Fri Sep 13 12:49:57 2013
UTC
@@ -473,7 +473,7 @@
"automatically set the debug break flag when debugger commands
are "
"in the queue")
DEFINE_bool(enable_liveedit, true, "enable liveedit experimental feature")
-DEFINE_bool(break_on_abort, true, "always cause a debug break before
aborting")
+DEFINE_bool(break_on_abort, false, "always cause a debug break before
aborting")
// execution.cc
// Slightly less than 1MB on 64-bit, since Windows' default stack size for
=======================================
--- /branches/bleeding_edge/src/platform-posix.cc Wed Sep 11 18:30:01 2013
UTC
+++ /branches/bleeding_edge/src/platform-posix.cc Fri Sep 13 12:49:57 2013
UTC
@@ -222,7 +222,7 @@
if (FLAG_break_on_abort) {
DebugBreak();
}
- abort();
+ V8_IMMEDIATE_CRASH();
}
=======================================
--- /branches/bleeding_edge/src/platform-win32.cc Fri Sep 13 10:35:35 2013
UTC
+++ /branches/bleeding_edge/src/platform-win32.cc Fri Sep 13 12:49:57 2013
UTC
@@ -872,10 +872,8 @@
void OS::Abort() {
if (IsDebuggerPresent() || FLAG_break_on_abort) {
DebugBreak();
- } else {
- // Make the MSVCRT do a silent abort.
- raise(SIGABRT);
}
+ V8_IMMEDIATE_CRASH();
}
=======================================
--- /branches/bleeding_edge/src/platform.h Fri Sep 13 10:35:35 2013 UTC
+++ /branches/bleeding_edge/src/platform.h Fri Sep 13 12:49:57 2013 UTC
@@ -51,6 +51,13 @@
#include "utils.h"
#include "v8globals.h"
+// This is lined up with blink's method of crashing.
+#if defined(__GNUC__)
+#define V8_IMMEDIATE_CRASH() __builtin_trap()
+#else
+#define V8_IMMEDIATE_CRASH() ((void(*)())0)()
+#endif
+
#ifdef __sun
# ifndef signbit
namespace std {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
