Thanks for finding that issue Ulan! It does seem to have fixed it (I've been
running your crash script for 10mins and no crashes, where before it crashed
after 2mins).
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc#newcode484
src/arm/codegen-arm.cc:484: __ ldr(r4, FieldMemOperand(r2,
JSObject::kElementsOffset));
On 2013/09/13 13:58:22, ulan wrote:
FieldMemOperand(r2, JSObject::kElementsOffset) is overwritten above in
line 473.
Ahh, you're right, nice spot! Fixed by moving up.
https://codereview.chromium.org/21063002/diff/82001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://codereview.chromium.org/21063002/diff/82001/src/arm/codegen-arm.cc#newcode484
src/arm/codegen-arm.cc:484: __ ldr(r4, FieldMemOperand(r2,
JSObject::kElementsOffset));
On 2013/09/13 14:20:48, ulan wrote:
Moving this up to line 454 seems to have fixed the flaky failure.
Done.
https://codereview.chromium.org/21063002/diff/82001/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
https://codereview.chromium.org/21063002/diff/82001/src/arm/macro-assembler-arm.h#newcode48
src/arm/macro-assembler-arm.h:48: const Register pp = { 7 }; //
Constant pool pointer.
On 2013/09/13 14:14:40, Rodolph Perfetta wrote:
nit: why don't you use kRegister_r7_Code like in assembler-arm.h? It
makes it
easier to look for r7 aliases.
Done (and done for cp and kRootRegister below).
https://codereview.chromium.org/21063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
