https://chromiumcodereview.appspot.com/24088003/diff/17001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/24088003/diff/17001/src/hydrogen.cc#newcode4565
src/hydrogen.cc:4565: static bool IsCompatibleForLoad(LookupResult*
result,
It isn't clear to me exactly what each of the parameters mean, just
based on the name. For example, IsXXXX implies (at least to me) some
singular thing is being checked--but here we're checked a whole bunch of
different criteria are compatible.
https://chromiumcodereview.appspot.com/24088003/diff/17001/src/hydrogen.cc#newcode4606
src/hydrogen.cc:4606: static bool AccessFromLookup(LookupResult* lookup,
Ow, this still hurts. We're taking in three pointers and potentially
updating two of them (maybe all three?).
https://chromiumcodereview.appspot.com/24088003/diff/17001/src/hydrogen.cc#newcode4615
src/hydrogen.cc:4615: return LookupGetter(map, name, getter, &holder);
E.g. this little bastard still takes two pointers to handles!
https://chromiumcodereview.appspot.com/24088003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
