https://codereview.chromium.org/24120006/diff/1/src/heap-snapshot-generator.h
File src/heap-snapshot-generator.h (right):

https://codereview.chromium.org/24120006/diff/1/src/heap-snapshot-generator.h#newcode646
src/heap-snapshot-generator.h:646: uint32_t len = strlen(s);
Would be nice to have a type cast here. Otherwise it might cause
error/warning on x64 (Win64 in particular).

Also consider using int instead as HashSequentialString accepts int.

https://codereview.chromium.org/24120006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to