LGTM with nits
https://codereview.chromium.org/23703014/diff/14001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/23703014/diff/14001/src/arm/lithium-arm.cc#newcode759
src/arm/lithium-arm.cc:759: LOperand* left = (op == Token::MOD)
Refactor this into
if (op == Token::MOD) {
...
} else {
...
}
with nothing outside the "if". We basically have 2 different
instructions here, and we should be honest about it. It improves
readability, and we shift towards that style at other places, too.
https://codereview.chromium.org/23703014/diff/14001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/23703014/diff/14001/src/ia32/lithium-ia32.cc#newcode814
src/ia32/lithium-ia32.cc:814: if (op == Token::MOD) return
MarkAsCall(DefineSameAsFirst(result), instr);
This is a border case: Personally I would prefer the same refactoring as
for the other platforms, even if that means some code duplication. But
I'll leave this up to you.
https://codereview.chromium.org/23703014/diff/14001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/23703014/diff/14001/src/x64/lithium-x64.cc#newcode764
src/x64/lithium-x64.cc:764: LOperand* right = (op == Token::MOD)
Same remark for MOD here...
https://codereview.chromium.org/23703014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
