https://codereview.chromium.org/23503058/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/23503058/diff/1/src/hydrogen-instructions.h#newcode3884
src/hydrogen-instructions.h:3884: if (left->IsForceRepresentation()) {
Why do we propagate back only to HForceRepresentation? This looks
weird...
https://codereview.chromium.org/23503058/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/23503058/diff/1/src/hydrogen.cc#newcode7698
src/hydrogen.cc:7698: } else if (expected->Is(Type::Signed32())) {
Just drop the "else", it's cleaner... :-)
https://codereview.chromium.org/23503058/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/23503058/diff/1/src/hydrogen.h#newcode1326
src/hydrogen.h:1326: HControlInstruction* compare = new(zone())
Condition(p1);
This template and the following 2 should probably be rewritten by
calling the non-negated version plus a SwapSuccessors (or whatever you
call it). Another possibility would be an optional argument so
AddCompare could do the right thing without a fixup afterwards.
https://codereview.chromium.org/23503058/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
