LGTM if comment about the stack guard is addressed.
https://codereview.chromium.org/23902033/diff/1/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/23902033/diff/1/src/optimizing-compiler-thread.cc#newcode140
src/optimizing-compiler-thread.cc:140: osr_candidates_.Clear();
As discussed offline: It is really scary that "osr_candidates_" is a
simple list, but it's only a temporary solution.
https://codereview.chromium.org/23902033/diff/1/src/optimizing-compiler-thread.cc#newcode206
src/optimizing-compiler-thread.cc:206:
isolate_->stack_guard()->Continue(INSTALL_CODE);
Please move this back into Execution::HandleStackGuardInterrupt, this
has nothing to do with the compiler thread, it is specific to how we
handle stack guards.
https://codereview.chromium.org/23902033/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
