lgtm with nits
https://codereview.chromium.org/23601031/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23601031/diff/1/src/objects.cc#newcode1975
src/objects.cc:1975:
new_map->set_unused_property_fields(unused_property_fields);
Can we move these lines changing the "unused property fields" into
CopyAddFieldDescriptor?
https://codereview.chromium.org/23601031/diff/1/src/objects.cc#newcode3783
src/objects.cc:3783: handle(lookup->holder()), name, value, attributes,
kNonStrictMode,
what about getting the receiver as input directly from the caller of
this method, rather than passing it through LookupResult and always
re-handlifying it?
https://codereview.chromium.org/23601031/diff/1/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/23601031/diff/1/src/stub-cache.cc#newcode1400
src/stub-cache.cc:1400: Handle<JSObject> recv(JSObject::cast(args[0]));
CONVERT_ARG_HANDLE_CHECKED(JSObject, 0, recv);
...
https://codereview.chromium.org/23601031/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
