Revision: 16749
Author:   [email protected]
Date:     Tue Sep 17 08:31:56 2013 UTC
Log:      Use icu_gyp_path variable to reference ICU gyp file

That way, embedders can put the icu sources whereever they want and
aren't forced to put them under third_party/gyp

BUG=none
[email protected]

Review URL: https://codereview.chromium.org/23598011
http://code.google.com/p/v8/source/detail?r=16749

Modified:
 /branches/bleeding_edge/build/standalone.gypi
 /branches/bleeding_edge/samples/samples.gyp
 /branches/bleeding_edge/src/d8.gyp
 /branches/bleeding_edge/tools/gyp/v8.gyp

=======================================
--- /branches/bleeding_edge/build/standalone.gypi Thu Aug 1 19:20:01 2013 UTC +++ /branches/bleeding_edge/build/standalone.gypi Tue Sep 17 08:31:56 2013 UTC
@@ -77,6 +77,9 @@
     # as errors.
     'v8_code%': 0,

+    # Relative path to icu.gyp from this file.
+    'icu_gyp_path': '../third_party/icu/icu.gyp',
+
     'conditions': [
       ['(v8_target_arch=="arm" and host_arch!="arm") or \
         (v8_target_arch=="mipsel" and host_arch!="mipsel") or \
=======================================
--- /branches/bleeding_edge/samples/samples.gyp Thu Jul 11 11:01:00 2013 UTC
+++ /branches/bleeding_edge/samples/samples.gyp Tue Sep 17 08:31:56 2013 UTC
@@ -42,13 +42,13 @@
     'conditions': [
       ['v8_enable_i18n_support==1', {
         'dependencies': [
-          '<(DEPTH)/third_party/icu/icu.gyp:icui18n',
-          '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
+          '<(icu_gyp_path):icui18n',
+          '<(icu_gyp_path):icuuc',
         ],
       }],
       ['OS=="win" and v8_enable_i18n_support==1', {
         'dependencies': [
-          '<(DEPTH)/third_party/icu/icu.gyp:icudata',
+          '<(icu_gyp_path):icudata',
         ],
       }],
     ],
=======================================
--- /branches/bleeding_edge/src/d8.gyp  Thu Jul 11 11:01:00 2013 UTC
+++ /branches/bleeding_edge/src/d8.gyp  Tue Sep 17 08:31:56 2013 UTC
@@ -81,13 +81,13 @@
         }],
         ['v8_enable_i18n_support==1', {
           'dependencies': [
-            '<(DEPTH)/third_party/icu/icu.gyp:icui18n',
-            '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
+            '<(icu_gyp_path):icui18n',
+            '<(icu_gyp_path):icuuc',
           ],
         }],
         ['OS=="win" and v8_enable_i18n_support==1', {
           'dependencies': [
-            '<(DEPTH)/third_party/icu/icu.gyp:icudata',
+            '<(icu_gyp_path):icudata',
           ],
         }],
       ],
=======================================
--- /branches/bleeding_edge/tools/gyp/v8.gyp    Thu Sep 12 13:50:38 2013 UTC
+++ /branches/bleeding_edge/tools/gyp/v8.gyp    Tue Sep 17 08:31:56 2013 UTC
@@ -855,8 +855,8 @@
         }],
         ['v8_enable_i18n_support==1', {
           'dependencies': [
-            '<(DEPTH)/third_party/icu/icu.gyp:icui18n',
-            '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
+            '<(icu_gyp_path):icui18n',
+            '<(icu_gyp_path):icuuc',
           ]
         }, {  # v8_enable_i18n_support==0
           'sources!': [
@@ -866,7 +866,7 @@
         }],
         ['OS=="win" and v8_enable_i18n_support==1', {
           'dependencies': [
-            '<(DEPTH)/third_party/icu/icu.gyp:icudata',
+            '<(icu_gyp_path):icudata',
           ],
         }],
       ],

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to