Reviewers: jochen,
Message:
On 2013/09/17 10:53:23, jochen wrote:
https://codereview.chromium.org/23702044/diff/7001/Makefile
File Makefile (right):
https://codereview.chromium.org/23702044/diff/7001/Makefile#newcode129
Makefile:129: GYPFLAGS += -Dv8_enable_i18n_support=1
as soon as i18n is on by default, the flag will test for off
Shouldn't run-tests.py then also default to on, and have an option to
turn the
intl tests off?
Done. Like that, NaCl will go red on the bots after landing this and before
changing the bot, but that's ok. I'll rebase with
https://codereview.chromium.org/23003028 as soon as it lands.
PTAL
Description:
Make testing i18n configurable.
If i18n support is on when building with make, the intl test suite is
automatically run with "check".
On the bots, we'll turn it on explicitly.
Please review this at https://codereview.chromium.org/23702044/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -1 lines):
M Makefile
M tools/run-tests.py
Index: Makefile
diff --git a/Makefile b/Makefile
index
288c257396de19895d85a6d399c520e939d5cb02..e58a7bdd9d9c597895b4e34bc16ca52e03249a04
100644
--- a/Makefile
+++ b/Makefile
@@ -127,6 +127,8 @@ endif
# i18nsupport=on
ifeq ($(i18nsupport), on)
GYPFLAGS += -Dv8_enable_i18n_support=1
+else
+ TESTFLAGS += --noi18n
endif
# arm specific flags.
# armv7=false/true
@@ -331,7 +333,7 @@ $(addsuffix .check, $(ANDROID_ARCHES)): \
$(addsuffix .check, $(NACL_BUILDS)): $$(basename $$@)
@tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR) \
--arch-and-mode=$(basename $@) \
- --timeout=600 --nopresubmit \
+ --timeout=600 --nopresubmit --noi18n \
--command-prefix="tools/nacl-run.py"
$(addsuffix .check, $(NACL_ARCHES)): \
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
48682d4444e586c8b48b1c146898b0dc17468ba8..1fd13ba803492023d8a1bc7d960395c4254c7857
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -112,6 +112,9 @@ def BuildOptions():
result.add_option("-m", "--mode",
help="The test modes in which to run
(comma-separated)",
default="release,debug")
+ result.add_option("--no-i18n", "--noi18n",
+ help="Whether to test internationalization",
+ default=False, action="store_true")
result.add_option("--no-network", "--nonetwork",
help="Don't distribute tests on the network",
default=(utils.GuessOS() != "linux"),
@@ -210,6 +213,8 @@ def ProcessOptions(options):
if not options.flaky_tests in ["run", "skip", "dontcare"]:
print "Unknown flaky test mode %s" % options.flaky_tests
return False
+ if not options.no_i18n:
+ DEFAULT_TESTS.append("intl")
return True
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
