https://codereview.chromium.org/24065005/diff/5001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/24065005/diff/5001/include/v8.h#newcode3870
include/v8.h:3870: typedef void (*GCPrologueCallback)(GCType type,
GCCallbackFlags flags);
On 2013/09/17 11:25:19, Sven Panne wrote:
Does this even compile with the new definitions below?

Sure.  They are in the v8::Isolate:: namespace.  I can move them back to
v8:: after blink is cutover

https://codereview.chromium.org/24065005/diff/5001/include/v8.h#newcode3873
include/v8.h:3873: typedef void (*GCCallback)();
On 2013/09/17 11:25:19, Sven Panne wrote:
We can remove this, I think...

on it.

https://codereview.chromium.org/24065005/diff/5001/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/24065005/diff/5001/src/heap.h#newcode2039
src/heap.h:2039: bool pass_isolate_;
On 2013/09/17 11:25:19, Sven Panne wrote:
Why do we need this flag? It seems like there is only 1 kind of
callback left
after this CL. Or I'm confused...

No, there's still two.  I have to cut blink over and then go through and
delete a bunch of stuff

https://codereview.chromium.org/24065005/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to