Reviewers: Michael Starzinger,
Description:
remove js_accessor_ics flag
[email protected]
BUG=
Please review this at https://codereview.chromium.org/24200002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -8 lines):
M src/flag-definitions.h
M src/ic.cc
M test/cctest/test-accessors.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
cc153af2542dfca612c4e12c579318931190acbd..4167c4200cb9088d87f498da54493136434e5a19
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -544,7 +544,6 @@ DEFINE_bool(use_idle_notification, true,
"Use idle notification to reduce memory footprint.")
// ic.cc
DEFINE_bool(use_ic, true, "use inline caching")
-DEFINE_bool(js_accessor_ics, false, "create ics for js accessors")
// macro-assembler-ia32.cc
DEFINE_bool(native_code_counters, false,
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index
992df1b1b0a0f13fb9a209dfde51dd9d5a915fe9..163172d8eb4df42e68c395c528f1864fb68ca49c
100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1365,8 +1365,7 @@ Handle<Code> LoadIC::ComputeLoadHandler(LookupResult*
lookup,
Handle<JSFunction> function = Handle<JSFunction>::cast(getter);
CallOptimization call_optimization(function);
if (call_optimization.is_simple_api_call() &&
- call_optimization.IsCompatibleReceiver(*receiver) &&
- FLAG_js_accessor_ics) {
+ call_optimization.IsCompatibleReceiver(*receiver)) {
return isolate()->stub_cache()->ComputeLoadCallback(
name, receiver, holder, call_optimization);
}
@@ -1577,8 +1576,7 @@ Handle<Code>
KeyedLoadIC::ComputeLoadHandler(LookupResult* lookup,
Handle<JSFunction> function = Handle<JSFunction>::cast(getter);
CallOptimization call_optimization(function);
if (call_optimization.is_simple_api_call() &&
- call_optimization.IsCompatibleReceiver(*receiver) &&
- FLAG_js_accessor_ics) {
+ call_optimization.IsCompatibleReceiver(*receiver)) {
return isolate()->stub_cache()->ComputeKeyedLoadCallback(
name, receiver, holder, call_optimization);
}
@@ -1856,8 +1854,7 @@ Handle<Code>
StoreIC::ComputeStoreMonomorphic(LookupResult* lookup,
Handle<JSFunction> function = Handle<JSFunction>::cast(setter);
CallOptimization call_optimization(function);
if (call_optimization.is_simple_api_call() &&
- call_optimization.IsCompatibleReceiver(*receiver) &&
- FLAG_js_accessor_ics) {
+ call_optimization.IsCompatibleReceiver(*receiver)) {
return isolate()->stub_cache()->ComputeStoreCallback(
name, receiver, holder, call_optimization, strict_mode);
}
Index: test/cctest/test-accessors.cc
diff --git a/test/cctest/test-accessors.cc b/test/cctest/test-accessors.cc
index
2aaac922bfbe2e49d22766727e126e6adefec235..ce8ab19db52548e84ff6ae9ce91b2107956a4171
100644
--- a/test/cctest/test-accessors.cc
+++ b/test/cctest/test-accessors.cc
@@ -554,7 +554,7 @@ THREADED_TEST(JSONStringifyNamedInterceptorObject) {
}
-THREADED_TEST(CrossContextAccess) {
+THREADED_TEST(AccessorPropertyCrossContext) {
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
v8::HandleScope scope(isolate);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
