LGTM if comment is addressed.
https://codereview.chromium.org/23654041/diff/3001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/23654041/diff/3001/src/hydrogen-instructions.cc#newcode2584
src/hydrogen-instructions.cc:2584: Zone* zone, HGraphBuilder* builder) {
I don't like passing around the HGraphBuilder into HInstructions. I see
that this would give static guarantees that no-one introduces call to
this method outside the graph builder, but it destroys decoupling please
revert this part of the change and just keep the fix in
HConstant::CopyToTruncatedInt32.
https://codereview.chromium.org/23654041/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
