On 2013/09/17 12:29:43, jochen wrote:
On 2013/09/17 11:12:56, machenbach wrote:
> On 2013/09/17 10:53:23, jochen wrote:
> > https://codereview.chromium.org/23702044/diff/7001/Makefile
> > File Makefile (right):
> >
> > https://codereview.chromium.org/23702044/diff/7001/Makefile#newcode129
> > Makefile:129: GYPFLAGS += -Dv8_enable_i18n_support=1
> > as soon as i18n is on by default, the flag will test for off
> >
> > Shouldn't run-tests.py then also default to on, and have an option to
turn
the
> > intl tests off?
>
> Done. Like that, NaCl will go red on the bots after landing this and
before
> changing the bot, but that's ok. I'll rebase with
> https://codereview.chromium.org/23003028 as soon as it lands.
>
> PTAL
Why not just add --noi18n to Makefile.nacl?
The bots call run-tests.py directly without going through a Makefile.
https://codereview.chromium.org/23702044/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
