LGTM, but like to suggest you add an enum for code-readability, for the
existing
boolean that lets us emit a return within the LeaveExitFrame macro.
https://codereview.chromium.org/23475052/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):
https://codereview.chromium.org/23475052/diff/1/src/mips/code-stubs-mips.cc#newcode2879
src/mips/code-stubs-mips.cc:2879: __ LeaveExitFrame(save_doubles_, s0,
true, true);
Use new enum EMIT_RETURN.
https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):
https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips.cc#newcode3954
src/mips/macro-assembler-mips.cc:3954: LeaveExitFrame(false, s0,
!restore_context, true);
Use new enum EMIT_RETURN.
https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips.h
File src/mips/macro-assembler-mips.h (right):
https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips.h#newcode852
src/mips/macro-assembler-mips.h:852: bool do_return = false);
To make the code more readable, I'd like to see an enum defined for this
do_return flag. Maybe EMIT_RETURN or some other name that would make
sense at the calls-site. Define the enum at the start of this file,
something like this:
enum LeaveExitFrameMode {
EMIT_RETRUN = true;
NO_EMIT_RETURN = false;
};
Then above is bool do_return = NO_EMIT_RETURN;
https://codereview.chromium.org/23475052/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
