Revision: 16785
Author: [email protected]
Date: Wed Sep 18 08:58:01 2013 UTC
Log: Make testing i18n the default.
If i18n support is on when building with make, the intl test suite is
automatically run with "check".
On the bots, we'll turn it off explicitly, where required.
[email protected]
Review URL: https://codereview.chromium.org/23702044
http://code.google.com/p/v8/source/detail?r=16785
Modified:
/branches/bleeding_edge/Makefile
/branches/bleeding_edge/tools/run-tests.py
=======================================
--- /branches/bleeding_edge/Makefile Wed Sep 18 08:11:44 2013 UTC
+++ /branches/bleeding_edge/Makefile Wed Sep 18 08:58:01 2013 UTC
@@ -127,6 +127,7 @@
# i18nsupport=off
ifeq ($(i18nsupport), off)
GYPFLAGS += -Dv8_enable_i18n_support=0
+ TESTFLAGS += --noi18n
endif
# arm specific flags.
# armv7=false/true
@@ -331,7 +332,7 @@
$(addsuffix .check, $(NACL_BUILDS)): $$(basename $$@)
@tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR) \
--arch-and-mode=$(basename $@) \
- --timeout=600 --nopresubmit \
+ --timeout=600 --nopresubmit --noi18n \
--command-prefix="tools/nacl-run.py"
$(addsuffix .check, $(NACL_ARCHES)): \
=======================================
--- /branches/bleeding_edge/tools/run-tests.py Thu Sep 12 07:39:44 2013 UTC
+++ /branches/bleeding_edge/tools/run-tests.py Wed Sep 18 08:58:01 2013 UTC
@@ -112,6 +112,9 @@
result.add_option("-m", "--mode",
help="The test modes in which to run
(comma-separated)",
default="release,debug")
+ result.add_option("--no-i18n", "--noi18n",
+ help="Skip internationalization tests",
+ default=False, action="store_true")
result.add_option("--no-network", "--nonetwork",
help="Don't distribute tests on the network",
default=(utils.GuessOS() != "linux"),
@@ -210,6 +213,8 @@
if not options.flaky_tests in ["run", "skip", "dontcare"]:
print "Unknown flaky test mode %s" % options.flaky_tests
return False
+ if not options.no_i18n:
+ DEFAULT_TESTS.append("intl")
return True
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
