On 2013/09/17 10:37:24, Toon Verwaest wrote:
https://codereview.chromium.org/23604062/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):
https://codereview.chromium.org/23604062/diff/1/src/hydrogen-instructions.h#oldcode2674
src/hydrogen-instructions.h:2674: object_unique_id_ =
UniqueValueId(object_);
So I guess you'll have to do something like this as well...
https://codereview.chromium.org/23604062/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/23604062/diff/1/src/hydrogen-instructions.h#newcode2628
src/hydrogen-instructions.h:2628: Unique<JSFunction> target(func);
Allocating this in the middle of graph-building isn't safe. We allocate
heap-objects during graph creation, potentially causing GC. We should
only be
able to construct Unique objects in a DisallowHeapAllocation scope;
otherwise
the resulting objects can't guarantee anything. (Granted, it does work for
immovable objects, but we should clearly indicate that if we rely on such
information anywhere).
I've added the notion of an "uninitialized" Unique<T>. Now we first
initialize
an HCheckValue to be unitialized and then finalize it like as before. This
reestablishes the "all uniqueness properties are computed at the same time"
kind
of invariant. Note we don't do that for HCheckMaps, since we assume that
maps
don't move.
https://codereview.chromium.org/23604062/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
