On 2013/09/18 09:30:06, Yang wrote:
LGTM with comments.
https://codereview.chromium.org/23619076/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/23619076/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode352
src/ia32/lithium-codegen-ia32.cc:352: __ test(ebx,
Immediate(kPointerSize));
Couldn't you test ebp directly? Something like
test(ebp, Immediate(kPointerSize));
j(zero, &do_not_pad)
Nice catch. Done.
https://codereview.chromium.org/23619076/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode372
src/ia32/lithium-codegen-ia32.cc:372: __ bind(&do_not_pad);
You can probably save a instruction per loop if you use ecx as negative
index
with ebp as base pointer, and increment ecx by a word in each loop until
it
hits
zero.
But this is easier to read, so I'm also fine with this.
Yeah, this was a cut-n-paste job from above :)
https://codereview.chromium.org/23619076/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
