On 2013/09/18 19:13:39, dcarney wrote:
On 2013/09/18 16:09:45, adamk wrote:
> https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc
> File src/d8-readline.cc (right):
>
>
https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc#newcode170
> src/d8-readline.cc:170: current_completions.Reset(isolate,
Handle<Array>());
> On 2013/09/18 07:17:02, dcarney wrote:
> > On 2013/09/18 00:22:42, adamk wrote:
> > > This one I'm not so sure about...
> >
> > should just be Reset()
>
> Hmm, I tried that before and got a crash...will try again when I get in.
Ok, well I don't really understand that, but it can't matter too much.
Just
keep what you've got then.
lgtm
Got it working with the proper version of Reset(), dunno what was up before.
https://codereview.chromium.org/23537060/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
