Revision: 16827
Author: [email protected]
Date: Thu Sep 19 12:07:03 2013 UTC
Log: Turn on i18n support by default
This reverts commit r16789
BUG=none
[email protected], [email protected]
Review URL: https://codereview.chromium.org/23522063
http://code.google.com/p/v8/source/detail?r=16827
Modified:
/branches/bleeding_edge/Makefile
/branches/bleeding_edge/Makefile.nacl
/branches/bleeding_edge/build/features.gypi
/branches/bleeding_edge/build/standalone.gypi
/branches/bleeding_edge/samples/samples.gyp
/branches/bleeding_edge/src/d8.gyp
/branches/bleeding_edge/test/mozilla/mozilla.status
/branches/bleeding_edge/test/test262/test262.status
/branches/bleeding_edge/tools/run-tests.py
=======================================
--- /branches/bleeding_edge/Makefile Wed Sep 18 13:50:00 2013 UTC
+++ /branches/bleeding_edge/Makefile Thu Sep 19 12:07:03 2013 UTC
@@ -124,9 +124,10 @@
ifeq ($(regexp), interpreted)
GYPFLAGS += -Dv8_interpreted_regexp=1
endif
-# i18nsupport=on
-ifeq ($(i18nsupport), on)
- GYPFLAGS += -Dv8_enable_i18n_support=1
+# i18nsupport=off
+ifeq ($(i18nsupport), off)
+ GYPFLAGS += -Dv8_enable_i18n_support=0
+ TESTFLAGS += --noi18n
endif
# arm specific flags.
# armv7=false/true
@@ -331,7 +332,7 @@
$(addsuffix .check, $(NACL_BUILDS)): $$(basename $$@)
@tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR) \
--arch-and-mode=$(basename $@) \
- --timeout=600 --nopresubmit \
+ --timeout=600 --nopresubmit --noi18n \
--command-prefix="tools/nacl-run.py"
$(addsuffix .check, $(NACL_ARCHES)): \
=======================================
--- /branches/bleeding_edge/Makefile.nacl Wed Sep 18 13:50:00 2013 UTC
+++ /branches/bleeding_edge/Makefile.nacl Thu Sep 19 12:07:03 2013 UTC
@@ -73,6 +73,9 @@
# For mksnapshot host generation.
GYPENV += host_os=${HOST_OS}
+
+# ICU doesn't support NaCl.
+GYPENV += v8_enable_i18n_support=0
NACL_MAKEFILES = $(addprefix $(OUTDIR)/Makefile.,$(NACL_ARCHES))
.SECONDEXPANSION:
=======================================
--- /branches/bleeding_edge/build/features.gypi Wed Sep 18 13:50:00 2013 UTC
+++ /branches/bleeding_edge/build/features.gypi Thu Sep 19 12:07:03 2013 UTC
@@ -54,7 +54,7 @@
# Enable ECMAScript Internationalization API. Enabling this feature
will
# add a dependency on the ICU library.
- 'v8_enable_i18n_support%': 0,
+ 'v8_enable_i18n_support%': 1,
},
'target_defaults': {
'conditions': [
=======================================
--- /branches/bleeding_edge/build/standalone.gypi Wed Sep 18 13:50:00 2013
UTC
+++ /branches/bleeding_edge/build/standalone.gypi Thu Sep 19 12:07:03 2013
UTC
@@ -36,7 +36,7 @@
'clang%': 0,
'visibility%': 'hidden',
'v8_enable_backtrace%': 0,
- 'v8_enable_i18n_support%': 0,
+ 'v8_enable_i18n_support%': 1,
'msvs_multi_core_compile%': '1',
'mac_deployment_target%': '10.5',
'variables': {
=======================================
--- /branches/bleeding_edge/samples/samples.gyp Wed Sep 18 13:50:00 2013 UTC
+++ /branches/bleeding_edge/samples/samples.gyp Thu Sep 19 12:07:03 2013 UTC
@@ -28,7 +28,7 @@
{
'variables': {
'v8_code': 1,
- 'v8_enable_i18n_support%': 0,
+ 'v8_enable_i18n_support%': 1,
},
'includes': ['../build/toolchain.gypi', '../build/features.gypi'],
'target_defaults': {
=======================================
--- /branches/bleeding_edge/src/d8.gyp Wed Sep 18 13:50:00 2013 UTC
+++ /branches/bleeding_edge/src/d8.gyp Thu Sep 19 12:07:03 2013 UTC
@@ -31,7 +31,7 @@
'console%': '',
# Enable support for Intel VTune. Supported on ia32/x64 only
'v8_enable_vtunejit%': 0,
- 'v8_enable_i18n_support%': 0,
+ 'v8_enable_i18n_support%': 1,
},
'includes': ['../build/toolchain.gypi', '../build/features.gypi'],
'targets': [
=======================================
--- /branches/bleeding_edge/test/mozilla/mozilla.status Wed Sep 18 13:50:00
2013 UTC
+++ /branches/bleeding_edge/test/mozilla/mozilla.status Thu Sep 19 12:07:03
2013 UTC
@@ -45,6 +45,12 @@
prefix mozilla
def FAIL_OK = FAIL, OKAY
+##################### NEEDS INVESTIGATION ##############
+
+# BUG(2893): These tests started to fail after i18n support was turned on.
Need
+# to investigate why.
+ecma_3/Number/15.7.4.3-02: PASS || FAIL
+ecma_3/Date/15.9.5.5-02: PASS || FAIL
##################### SKIPPED TESTS #####################
=======================================
--- /branches/bleeding_edge/test/test262/test262.status Wed Sep 18 13:50:00
2013 UTC
+++ /branches/bleeding_edge/test/test262/test262.status Thu Sep 19 12:07:03
2013 UTC
@@ -36,11 +36,6 @@
# V8 Bug: http://code.google.com/p/v8/issues/detail?id=691
11.2.3-3_3: FAIL
-# Strings that are considered canonically equivalent by the Unicode
standard
-# return a non-zero value on String.prototype.localeCompare calls.
-# V8 Bug: http://code.google.com/p/v8/issues/detail?id=2413
-15.5.4.9_CE: FAIL
-
##################### DELIBERATE INCOMPATIBILITIES #####################
# This tests precision of Math functions. The implementation for those
=======================================
--- /branches/bleeding_edge/tools/run-tests.py Wed Sep 18 13:50:00 2013 UTC
+++ /branches/bleeding_edge/tools/run-tests.py Thu Sep 19 12:07:03 2013 UTC
@@ -112,6 +112,9 @@
result.add_option("-m", "--mode",
help="The test modes in which to run
(comma-separated)",
default="release,debug")
+ result.add_option("--no-i18n", "--noi18n",
+ help="Skip internationalization tests",
+ default=False, action="store_true")
result.add_option("--no-network", "--nonetwork",
help="Don't distribute tests on the network",
default=(utils.GuessOS() != "linux"),
@@ -210,6 +213,8 @@
if not options.flaky_tests in ["run", "skip", "dontcare"]:
print "Unknown flaky test mode %s" % options.flaky_tests
return False
+ if not options.no_i18n:
+ DEFAULT_TESTS.append("intl")
return True
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
