Revision: 16830
Author:   [email protected]
Date:     Thu Sep 19 13:11:57 2013 UTC
Log:      Collect garbage before running mjsunit/fast-prototype

When not using a snapshot, after turning on i18n, there's just enough
garbage after creating a context to trigger gc at the wrong moment.
Since the test uses natives syntax to access information that would
otherwise be hidden from javascript, this makes the test fail

BUG=none
[email protected]
TEST=mjsunit/fast-prototype passes on ia32.release with no snapshot

Review URL: https://codereview.chromium.org/23452047
http://code.google.com/p/v8/source/detail?r=16830

Modified:
 /branches/bleeding_edge/test/mjsunit/fast-prototype.js

=======================================
--- /branches/bleeding_edge/test/mjsunit/fast-prototype.js Tue Dec 11 10:33:04 2012 UTC +++ /branches/bleeding_edge/test/mjsunit/fast-prototype.js Thu Sep 19 13:11:57 2013 UTC
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --allow-natives-syntax
+// Flags: --allow-natives-syntax --expose-gc

 // TODO(mstarzinger): This test does not succeed when GCs happen in
 // between prototype transitions, we disable GC stress for now.
@@ -84,6 +84,8 @@
   return proto;
 }

+// TODO(mstarzinger): This test fails easily if gc happens at the wrong time.
+gc();

 for (var i = 0; i < 4; i++) {
   var set__proto__ = ((i & 1) != 0);

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to