https://codereview.chromium.org/22801003/diff/2001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/22801003/diff/2001/src/ia32/code-stubs-ia32.cc#newcode4877
src/ia32/code-stubs-ia32.cc:4877: __ cmp(ebp, edx);
On 2013/09/13 09:47:56, Yang wrote:
Instead of these 4 instructions, you could just
__ cmp(ebp,
Operand::StaticVariable(c_entry_frame_to_ignore_exception));
__ mov(Operand::StaticVariable(c_entry_frame_to_ignore_exception),
Immediate(0));
I don't think mov sets any flags, so you can do the conditional jump
afterwards
based on the results of cmp.
Thanks a lot.
I also moved "clear" statement below the jump, because not matching
frames obviously mustn't clear this pointer.
https://codereview.chromium.org/22801003/diff/2001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/22801003/diff/2001/src/x64/code-stubs-x64.cc#newcode4022
src/x64/code-stubs-x64.cc:4022: __ cmpq(rbp, rdx);
On 2013/09/13 09:47:56, Yang wrote:
Similar to ia32.
Done.
https://codereview.chromium.org/22801003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
