inline question on your stack adjustment....
https://codereview.chromium.org/24233003/diff/1/src/mips/regexp-macro-assembler-mips.cc
File src/mips/regexp-macro-assembler-mips.cc (right):
https://codereview.chromium.org/24233003/diff/1/src/mips/regexp-macro-assembler-mips.cc#newcode1089
src/mips/regexp-macro-assembler-mips.cc:1089: __ lw(sp, MemOperand(sp,
16 + stack_alignment + kCArgsSlotsSize));
Where does the magic number 16 come from? You're calling
PrepareCallCFunction() with 3 args, but those fit within the (4)
on-stack ArgsSlots. You already account for that with kCArgsSlotsSize.
The only un-accounted for thing is the return address. That would be 4
bytes, or maybe 8 to preserve alignment.
https://codereview.chromium.org/24233003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
