Reviewers: dcarney,
Description:
Prevent test-log.cc from creating log files.
[email protected]
TEST=cctest/test-log/EquivalenceOfLoggingAndTraversal
Please review this at https://codereview.chromium.org/23526073/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -1 lines):
M src/flag-definitions.h
M src/log.cc
M test/cctest/test-log.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
e734c7d3c6429bce47455261a1bb36cec37dcafd..2c012511c46eb3d4319bc6f47eeebe714de35320
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -771,6 +771,7 @@ DEFINE_bool(prof_browser_mode, true,
"Used with --prof, turns on browser-compatible mode for
profiling.")
DEFINE_bool(log_regexp, false, "Log regular expression execution.")
DEFINE_string(logfile, "v8.log", "Specify the name of the log file.")
+DEFINE_bool(logfile_per_isolate, true, "Separate log files for each
isolate.")
DEFINE_bool(ll_prof, false, "Enable low-level linux profiler.")
DEFINE_string(gc_fake_mmap, "/tmp/__v8_gc__",
"Specify the name of the file for fake gc mmap used in
ll_prof")
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index
0f0ad40398f358f01cf0f35c7f65691d768b2770..10f4abd3497f6563e787464ea5d994a5689037c6
100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1773,7 +1773,7 @@ static void AddIsolateIdIfNeeded(Isolate* isolate,
StringStream* stream) {
static SmartArrayPointer<const char> PrepareLogFileName(
Isolate* isolate, const char* file_name) {
if (strchr(file_name, '%') != NULL ||
- !isolate->IsDefaultIsolate()) {
+ (FLAG_logfile_per_isolate && !isolate->IsDefaultIsolate())) {
// If there's a '%' in the log file name we have to expand
// placeholders.
HeapStringAllocator allocator;
Index: test/cctest/test-log.cc
diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc
index
d7cd876dd5305c5bd7e4722c481e90852fe1aae3..e9ce7e1731be076617803588b78828a44937af3b
100644
--- a/test/cctest/test-log.cc
+++ b/test/cctest/test-log.cc
@@ -91,6 +91,7 @@ class ScopedLoggerInitializer {
i::FLAG_log = true;
i::FLAG_prof = true;
i::FLAG_logfile = i::Log::kLogToTemporaryFile;
+ i::FLAG_logfile_per_isolate = false;
return false;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
