Thanks for the review. Addressed comments. Landing.
https://codereview.chromium.org/23976010/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4436
src/objects.cc:4436: Map* map(object->map());
On 2013/09/20 09:32:41, Toon Verwaest wrote:
Handle<Map>
Done.
https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4437
src/objects.cc:4437:
On 2013/09/20 09:32:41, Toon Verwaest wrote:
Given that no handle escapes this method, and since there's a loop,
lets insert
a new handle-scope here so these handles can be freed after
normalizing
properties.
Done.
https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4497
src/objects.cc:4497: // From here on we cannot fail and we shouldn't GC
anymore.
On 2013/09/20 09:32:41, Toon Verwaest wrote:
What about putting this into
{ DisallowHeapAllocation no_allocation;
...
}
rather than having a comment.
Done. Good point!
https://codereview.chromium.org/23976010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
