Revision: 16869
Author: [email protected]
Date: Fri Sep 20 13:19:40 2013 UTC
Log: don't use default isolate in mksnapshot
[email protected]
BUG=
Review URL: https://codereview.chromium.org/24258006
http://code.google.com/p/v8/source/detail?r=16869
Modified:
/branches/bleeding_edge/src/mksnapshot.cc
/branches/bleeding_edge/src/serialize.cc
=======================================
--- /branches/bleeding_edge/src/mksnapshot.cc Thu Sep 12 13:50:38 2013 UTC
+++ /branches/bleeding_edge/src/mksnapshot.cc Fri Sep 20 13:19:40 2013 UTC
@@ -310,6 +310,7 @@
int main(int argc, char** argv) {
V8::InitializeICU();
+ i::Isolate::SetCrashIfDefaultIsolateInitialized();
// By default, log code create information in the snapshot.
i::FLAG_log_code = true;
@@ -330,7 +331,10 @@
exit(1);
}
#endif
- Isolate* isolate = Isolate::GetCurrent();
+ i::FLAG_logfile_per_isolate = false;
+
+ Isolate* isolate = v8::Isolate::New();
+ isolate->Enter();
i::Isolate* internal_isolate = reinterpret_cast<i::Isolate*>(isolate);
i::Serializer::Enable(internal_isolate);
Persistent<Context> context;
=======================================
--- /branches/bleeding_edge/src/serialize.cc Wed Sep 11 07:14:41 2013 UTC
+++ /branches/bleeding_edge/src/serialize.cc Fri Sep 20 13:19:40 2013 UTC
@@ -1284,7 +1284,6 @@
root_index_wave_front_(0) {
// The serializer is meant to be used only to generate initial heap
images
// from a context in which there is only one isolate.
- ASSERT(isolate_->IsDefaultIsolate());
for (int i = 0; i <= LAST_SPACE; i++) {
fullness_[i] = 0;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.