Revision: 16870
Author: [email protected]
Date: Fri Sep 20 18:16:52 2013 UTC
Log: Fix d8-readline to use modern Persistent API
[email protected], [email protected]
Review URL: https://codereview.chromium.org/23537060
http://code.google.com/p/v8/source/detail?r=16870
Modified:
/branches/bleeding_edge/src/d8-readline.cc
=======================================
--- /branches/bleeding_edge/src/d8-readline.cc Fri Jun 14 13:40:47 2013 UTC
+++ /branches/bleeding_edge/src/d8-readline.cc Fri Sep 20 18:16:52 2013 UTC
@@ -150,7 +150,7 @@
static Persistent<Array> current_completions;
Isolate* isolate = read_line_editor.isolate_;
Locker lock(isolate);
- HandleScope scope;
+ HandleScope scope(isolate);
Handle<Array> completions;
if (state == 0) {
Local<String> full_text = String::New(rl_line_buffer, rl_point);
@@ -167,8 +167,7 @@
String::Utf8Value str(str_obj);
return strdup(*str);
} else {
- current_completions.Dispose(isolate);
- current_completions.Clear();
+ current_completions.Reset();
return NULL;
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
