I rebased with master and marked the changes needing review between
patchset 4
and patchset 5. I verified X32 port could run successfully with the changes
between them.
https://codereview.chromium.org/22267005/diff/24001/src/arguments.h
File src/arguments.h (right):
https://codereview.chromium.org/22267005/diff/24001/src/arguments.h#newcode241
src/arguments.h:241: static const int kContextSaveIndex =
T::kContextSaveIndex;
This change needs review.
https://codereview.chromium.org/22267005/diff/24001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/22267005/diff/24001/src/x64/stub-cache-x64.cc#newcode527
src/x64/stub-cache-x64.cc:527: StackArgumentsAccessor args_from_rbp(rbp,
kFastApiCallArguments,
Line 527 to 538 needs review.
https://codereview.chromium.org/22267005/diff/24001/src/x64/stub-cache-x64.cc#newcode1115
src/x64/stub-cache-x64.cc:1115: StackArgumentsAccessor args(rsp,
kFastApiCallArguments,
This needs review.
https://codereview.chromium.org/22267005/diff/24001/src/x64/stub-cache-x64.cc#newcode1398
src/x64/stub-cache-x64.cc:1398: // The name handler is counted as an
argument.
Line 1398 to 1407 need review.
https://codereview.chromium.org/22267005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
