https://codereview.chromium.org/23497009/diff/1/src/checks.cc
File src/checks.cc (right):
https://codereview.chromium.org/23497009/diff/1/src/checks.cc#newcode30
src/checks.cc:30: #if V8_LIBC_GLIBC || V8_OS_BSD
Does that include !defined(__UCLIBC__)?
https://codereview.chromium.org/23497009/diff/1/src/checks.cc#newcode84
src/checks.cc:84: fflush(stderr);
Why can that not stay within DumpBacktrace()?
https://codereview.chromium.org/23497009/diff/1/src/platform-macos.cc
File src/platform-macos.cc (left):
https://codereview.chromium.org/23497009/diff/1/src/platform-macos.cc#oldcode68
src/platform-macos.cc:68: // This lets us launch on 10.4 which does not
have these calls.
In the new code, execinfo.h will be included. Will it still work on
10.4?
https://codereview.chromium.org/23497009/diff/1/src/platform-posix.h
File src/platform-posix.h (left):
https://codereview.chromium.org/23497009/diff/1/src/platform-posix.h#oldcode60
src/platform-posix.h:60: #if !defined(ANDROID)
What if we are on Android in the new code? Why is it safe to remove the
#if?
https://codereview.chromium.org/23497009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
