Addressed some comments after offline discussion. PTAL.
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc#newcode2844
src/heap.cc:2844: AllocationSpace space = (pretenure == TENURED) ?
OLD_DATA_SPACE : NEW_SPACE;
On 2013/08/20 09:49:19, Hannes Payer wrote:
You can also use the select function here.
Done.
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc#newcode4044
src/heap.cc:4044: AllocationSpace space = (pretenure == TENURED) ?
OLD_DATA_SPACE : NEW_SPACE;
On 2013/08/20 09:49:19, Hannes Payer wrote:
You can also use the select function here.
Done.
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc#newcode4144
src/heap.cc:4144: MaybeObject* maybe_result;
On 2013/08/20 09:49:19, Hannes Payer wrote:
We could also clean up the code allocation with a proper select
function then
just calling space->AllocateRaw. lo_space could implement a
AllocateRaw(size)
wrapper for AllocateRaw(size, EXECUTABLE);
As discussed offline: Let's do this in a separate CL.
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc#newcode4357
src/heap.cc:4357: { MaybeObject* maybe_result =
On 2013/08/20 09:49:19, Hannes Payer wrote:
We could do a proper space selection here as well.
arguments_object_size could
become really big...?
As discussed offline: Let's do this in a separate CL.
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc#newcode5414
src/heap.cc:5414: AllocateRaw(size, OLD_DATA_SPACE, OLD_DATA_SPACE);
On 2013/08/20 09:49:19, Hannes Payer wrote:
For cases like that we could add an AllocateRaw(size, space) function
which is a
wrapper for AllocateRaw(size, space1, space2) if space1 == space2.
As discussed offline: Let's do this in a separate CL.
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc#newcode5439
src/heap.cc:5439: return size <= Page::kMaxNonCodeHeapObjectSize
On 2013/08/20 09:49:19, Hannes Payer wrote:
Can we merge this function with AllocateRawFixedArray(int length,
PretenureFlag
pretenure)?
As discussed offline: Let's do this in a separate CL.
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc#newcode5576
src/heap.cc:5576: AllocateRaw(size, OLD_DATA_SPACE, OLD_DATA_SPACE);
On 2013/08/20 09:49:19, Hannes Payer wrote:
here we could use the AllocateRaw(size, space) wrapper
As discussed offline: Let's do this in a separate CL.
https://codereview.chromium.org/22925004/diff/3001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/22925004/diff/3001/src/heap.h#newcode2084
src/heap.h:2084: // size and the given pretenuring decision.
On 2013/08/20 09:49:19, Hannes Payer wrote:
... and the given preferred old space if old data space or old pointer
space is
selected ...
Done.
https://codereview.chromium.org/22925004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
