https://codereview.chromium.org/24357002/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/24357002/diff/1/include/v8.h#newcode4518
include/v8.h:4518: * calling any other V8-related function.
On 2013/09/23 11:24:15, Dmitry Lomov (chromium) wrote:
This is vague; the true statement is that SetEntropySource should be
called
prior to V8::Intitialize.
Generally, we have a bunch of global parameter setters
(V8::SetEntropySource,
V8::SetArrayBufferAllocator, V8::SetReturnAddressLocationResolver etc)
that all
need to be called before V8::Initialize, but crucially do not depend
on each
other (otherwise it will be a nightmare to call correctly)
Done.
https://codereview.chromium.org/24357002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/24357002/diff/1/src/api.cc#newcode5190
src/api.cc:5190: return false;
On 2013/09/23 11:24:15, Dmitry Lomov (chromium) wrote:
I think just returning false will be ignored (also completely useless
for user
program - if the function returns false, there is no way for user
program to
recover). I think it will make much more sense to assert this (use
ApiCheck
function)
Done.
https://codereview.chromium.org/24357002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
