It's not entirely clear to me what problem you are fixing. Can we have a
test-case for this?
Previously if there was an interceptor setter, we'd always initialize the IC
because lookup->CanHoldValue(value) would always return true (given that
representation is Tagged).
Could it be that you are trying to fix a problem that was already fixed by
https://chromiumcodereview.appspot.com/23533012?
https://codereview.chromium.org/24272005/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/24272005/diff/1/src/ic.cc#newcode1618
src/ic.cc:1618: ASSERT(lookup->representation()->IsNone());
Why would the representation be none? It's explicitly set to Tagged in
InterceptorResult in src/property.h
https://codereview.chromium.org/24272005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
