LGTM, few nits.
https://codereview.chromium.org/23463047/diff/3001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/23463047/diff/3001/src/heap-snapshot-generator.cc#newcode1304
src/heap-snapshot-generator.cc:1304: SetInternalReference(site, entry,
"nested_sites", site->nested_sites(),
same same
https://codereview.chromium.org/23463047/diff/3001/src/objects-printer.cc
File src/objects-printer.cc (right):
https://codereview.chromium.org/23463047/diff/3001/src/objects-printer.cc#newcode1106
src/objects-printer.cc:1106: // Just print the number of nested sites
After discussing offline, let's print the nested site pointer and not
the number of nested sites.
https://codereview.chromium.org/23463047/diff/3001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23463047/diff/3001/src/objects.h#newcode7830
src/objects.h:7830: DECL_ACCESSORS(nested_sites, Object)
I think we should call it next or nested_sit and say in a comment that
this list represents the nested literals in a specific order.
https://codereview.chromium.org/23463047/diff/3001/src/objects.h#newcode7865
src/objects.h:7865: static const int kNestedSitesOffset =
kTransitionInfoOffset + kPointerSize;
kNextOffset or kNestedSiteOffset
https://codereview.chromium.org/23463047/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
