On 2013/09/25 07:00:30, mvstanton wrote:
Hi Weiliang, just one question below, thx!
--Michael

https://codereview.chromium.org/23531084/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):


https://codereview.chromium.org/23531084/diff/1/src/x64/macro-assembler-x64.cc#newcode3731
src/x64/macro-assembler-x64.cc:3731: int space =
XMMRegister::kMaxNumAllocatableRegisters * kDoubleSize +
Could you do the same thing on ia32, using
Register::kMaxNumAllocatableRegisters?

Thanks Michael, Why I don't do the same thing on ia32 is that in my memory, ia32
will keep some value in xmm0 when calling into runtime. So ia32 may
intentionally save all its 8 XMMRegsiters. An example is like the xmm_scratch in
DoDeferredNumberTagI.

https://codereview.chromium.org/23531084/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to