Reviewers: Jakob,

Message:
There was a function:
"
bool SharedFunctionInfo::IsBuiltinMathFunction() {
  return HasBuiltinFunctionId() &&
      builtin_function_id() >= kFirstMathFunctionId;
}
"
,but it was removed in https://codereview.chromium.org/6243008.

Description:
Remove unused kFirstMathFunctionId

Please review this at https://codereview.chromium.org/24537002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+1, -5 lines):
  M src/objects.h


Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 437e61ab9f2f040da1bcca423107fd0b9e9ab350..3f229a85bf308af1ba5cdb9d6b1d8847c49f0968 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -6207,9 +6207,6 @@ class Script: public Struct {
 //
 // Installation of ids for the selected builtin functions is handled
 // by the bootstrapper.
-//
-// NOTE: Order is important: math functions should be at the end of
-// the list and MathFloor should be the first math function.
 #define FUNCTIONS_WITH_ID_LIST(V)                   \
   V(Array.prototype, push, ArrayPush)               \
   V(Array.prototype, pop, ArrayPop)                 \
@@ -6244,8 +6241,7 @@ enum BuiltinFunctionId {
 #undef DECLARE_FUNCTION_ID
   // Fake id for a special case of Math.pow. Note, it continues the
   // list of math functions.
-  kMathPowHalf,
-  kFirstMathFunctionId = kMathFloor
+  kMathPowHalf
 };




--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to