Revision: 16937
Author: [email protected]
Date: Wed Sep 25 09:31:10 2013 UTC
Log: Remove obsolete global SubString method.
[email protected]
Review URL: https://codereview.chromium.org/24545002
http://code.google.com/p/v8/source/detail?r=16937
Modified:
/branches/bleeding_edge/src/handles.cc
/branches/bleeding_edge/src/handles.h
/branches/bleeding_edge/src/objects.cc
=======================================
--- /branches/bleeding_edge/src/handles.cc Fri Sep 13 09:51:11 2013 UTC
+++ /branches/bleeding_edge/src/handles.cc Wed Sep 25 09:31:10 2013 UTC
@@ -283,15 +283,6 @@
isolate,
isolate->heap()->LookupSingleCharacterStringFromCode(index), Object);
}
-
-
-Handle<String> SubString(Handle<String> str,
- int start,
- int end,
- PretenureFlag pretenure) {
- CALL_HEAP_FUNCTION(str->GetIsolate(),
- str->SubString(start, end, pretenure), String);
-}
// Wrappers for scripts are kept alive and cached in weak global
=======================================
--- /branches/bleeding_edge/src/handles.h Fri Sep 13 09:51:11 2013 UTC
+++ /branches/bleeding_edge/src/handles.h Wed Sep 25 09:31:10 2013 UTC
@@ -299,11 +299,6 @@
Handle<FixedArray> UnionOfKeys(Handle<FixedArray> first,
Handle<FixedArray> second);
-Handle<String> SubString(Handle<String> str,
- int start,
- int end,
- PretenureFlag pretenure = NOT_TENURED);
-
// Sets the expected number of properties for the function's instances.
void SetExpectedNofProperties(Handle<JSFunction> func, int nof);
=======================================
--- /branches/bleeding_edge/src/objects.cc Tue Sep 24 16:51:43 2013 UTC
+++ /branches/bleeding_edge/src/objects.cc Wed Sep 25 09:31:10 2013 UTC
@@ -9734,7 +9734,8 @@
Handle<Object> SharedFunctionInfo::GetSourceCode() {
if (!HasSourceCode()) return GetIsolate()->factory()->undefined_value();
Handle<String> source(String::cast(Script::cast(script())->source()));
- return SubString(source, start_position(), end_position());
+ return GetIsolate()->factory()->NewSubString(
+ source, start_position(), end_position());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
