On 2013/09/25 09:22:25, mvstanton wrote:
LGTM with one comment nit. You could rename the optimizing compiler
thread to
RecompilationThread for bonus symmetry points :p.
https://codereview.chromium.org/24543002/diff/1/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/24543002/diff/1/src/optimizing-compiler-thread.cc#newcode130
src/optimizing-compiler-thread.cc:130: // The optimizing compiler is
allocated
in the CompilationInfo's zone.
To // "The recompile job"
https://codereview.chromium.org/24543002/diff/1/src/optimizing-compiler-thread.cc#newcode146
src/optimizing-compiler-thread.cc:146: // The optimizing compiler is
allocated
in the CompilationInfo's zone.
Address this comment too.
I'd like to do that some other time. The reason is that it would be a lot
bigger
and would make updating the heap check suppression file necessary. I'd
rather
first fix the existing memory leak first so that the heap check suppression
entry can be deleted.
https://codereview.chromium.org/24543002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
