LGTM with comments. Thanks for fixing this!
https://codereview.chromium.org/24484003/diff/1/test/mjsunit/timer.js
File test/mjsunit/timer.js (right):
https://codereview.chromium.org/24484003/diff/1/test/mjsunit/timer.js#newcode30
test/mjsunit/timer.js:30: (function run(){
nit: space before '{'
https://codereview.chromium.org/24484003/diff/1/test/mjsunit/timer.js#newcode33
test/mjsunit/timer.js:33: for (var start = Date.now(); start -
start_test < 20; start = Date.now()) {
I think we can afford a higher upper limit. Maybe 100 ms?
And a nit: only one space before '<'
https://codereview.chromium.org/24484003/diff/1/test/mjsunit/timer.js#newcode38
test/mjsunit/timer.js:38: if (end - start <= 1) {
I'd prefer '==' here. 0 can't happen, negative values are undesirable.
https://codereview.chromium.org/24484003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
