LGTM if comments are addressed.
https://codereview.chromium.org/24550006/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/24550006/diff/1/src/api.cc#newcode700
src/api.cc:700: return reinterpret_cast<i::Object**>(
nit: The reinterpret_cast here should be obsolete.
https://codereview.chromium.org/24550006/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/24550006/diff/1/test/cctest/test-api.cc#newcode3311
test/cctest/test-api.cc:3311: =
v8::Local<String>::New(CcTest::isolate(), v8_str("str"));
nit: Move then assignment operator into the line above, indentation is
off.
https://codereview.chromium.org/24550006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
