https://codereview.chromium.org/24245005/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/24245005/diff/1/include/v8.h#newcode778
include/v8.h:778: // TODO(dcarney): deprecated - use
CloseableHandleScope::Close.
On 2013/09/26 09:48:11, Michael Starzinger wrote:
nit: s/Closeable/Escapeable/
Done.
https://codereview.chromium.org/24245005/diff/1/include/v8.h#newcode796
include/v8.h:796: V8_INLINE HandleScope() {}
On 2013/09/26 09:48:11, Michael Starzinger wrote:
I don't think we should expose these three methods, even if they are
only
protected. Could we instead make EscapableHandleScope a friend of this
class and
drop these three methods?
Done.
https://codereview.chromium.org/24245005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
