LGTM with nits
https://codereview.chromium.org/24725002/diff/1/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/24725002/diff/1/src/compiler.h#newcode536
src/compiler.h:536: bool IsCompilingForOSR() { return
!info()->osr_ast_id().IsNone(); }
I think there is an info.is_osr() method already.
https://codereview.chromium.org/24725002/diff/1/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/24725002/diff/1/src/optimizing-compiler-thread.cc#newcode154
src/optimizing-compiler-thread.cc:154: if (job->IsCompilingForOSR())
continue;
I think I like the nested version better.
https://codereview.chromium.org/24725002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
