On 2013/09/27 08:27:12, titzer wrote:
On 2013/09/17 13:47:12, Michael Starzinger wrote:
> PTAL. Addressed comments. Simplified. Rebased.
>
>
https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis.h
> File src/hydrogen-escape-analysis.h (right):
>
>
https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis.h#newcode49
> src/hydrogen-escape-analysis.h:49: void Run() {
> On 2013/08/30 11:19:29, titzer wrote:
> > I would move this method into the .cc file and make the "more_work"
variable
> > into the return value of the CollectCapturedValues() method--then you
don't
> need
> > a field.
>
> Done. After rebasing I can just check for "captured.is_empty()", much
simpler
> now with the latest version.
Was this CL made obsolete by your recent changes?
Nope, still needed, gives a nice performance boost.
https://codereview.chromium.org/23533003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
