On 2013/09/27 11:28:53, haitao.feng wrote:
It will be great if you could use StackArgumentsAccessor for all the
argument
access from rsp or rbp for X64 in this CL. Please see
https://codereview.chromium.org/22267005/patch/24001/25010 for the
changes I
have done over the recent commit.
Or I could upload a patchset for the argument access in this CL once it is
landed as danno has reviewed the other parts of argument accessing at
https://codereview.chromium.org/22267005/.
I'm not sure if StackArgumentsAccessor is the right way to go:
With StackArgumentsAccessor:
int offset = argc + kFastApiCallArguments;
__ movq(args.GetArgumentOperand(offset - FCA::kContextSaveIndex), rsi);
Without StackArgumentsAccessor:
__ str(cp, MemOperand(sp, FCA::kContextSaveIndex * kPointerSize));
I think the latter is less obscure regarding computing the index. danno,
wdyt?
https://codereview.chromium.org/24488006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
