Reviewers: Yang,
Message:
PTAL.
Description:
Refactor translation opcode a little in the deoptimization
Please review this at https://codereview.chromium.org/25480003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+29, -57 lines):
M src/deoptimizer.h
M src/deoptimizer.cc
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index
9a1bb9d8efb97e2193051079321f3b59d9219444..b532e927dda2aad6be18395db6af83c44beb07b7
100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -2736,46 +2736,11 @@ int Translation::NumberOfOperandsFor(Opcode opcode)
{
#if defined(OBJECT_PRINT) || defined(ENABLE_DISASSEMBLER)
const char* Translation::StringFor(Opcode opcode) {
+#define TRANSLATION_OPCODE_CASE(item) case item: return #item;
switch (opcode) {
- case BEGIN:
- return "BEGIN";
- case JS_FRAME:
- return "JS_FRAME";
- case ARGUMENTS_ADAPTOR_FRAME:
- return "ARGUMENTS_ADAPTOR_FRAME";
- case CONSTRUCT_STUB_FRAME:
- return "CONSTRUCT_STUB_FRAME";
- case GETTER_STUB_FRAME:
- return "GETTER_STUB_FRAME";
- case SETTER_STUB_FRAME:
- return "SETTER_STUB_FRAME";
- case COMPILED_STUB_FRAME:
- return "COMPILED_STUB_FRAME";
- case REGISTER:
- return "REGISTER";
- case INT32_REGISTER:
- return "INT32_REGISTER";
- case UINT32_REGISTER:
- return "UINT32_REGISTER";
- case DOUBLE_REGISTER:
- return "DOUBLE_REGISTER";
- case STACK_SLOT:
- return "STACK_SLOT";
- case INT32_STACK_SLOT:
- return "INT32_STACK_SLOT";
- case UINT32_STACK_SLOT:
- return "UINT32_STACK_SLOT";
- case DOUBLE_STACK_SLOT:
- return "DOUBLE_STACK_SLOT";
- case LITERAL:
- return "LITERAL";
- case DUPLICATED_OBJECT:
- return "DUPLICATED_OBJECT";
- case ARGUMENTS_OBJECT:
- return "ARGUMENTS_OBJECT";
- case CAPTURED_OBJECT:
- return "CAPTURED_OBJECT";
+ TRANSLATION_OPCODE_LIST(TRANSLATION_OPCODE_CASE)
}
+#undef TRANSLATION_OPCODE_CASE
UNREACHABLE();
return "";
}
Index: src/deoptimizer.h
diff --git a/src/deoptimizer.h b/src/deoptimizer.h
index
8c1699384c8f51de775768c65063124a73379987..931082171f9a0d8cfdf09c99e4c20f21a27a78c2
100644
--- a/src/deoptimizer.h
+++ b/src/deoptimizer.h
@@ -679,29 +679,36 @@ class TranslationIterator BASE_EMBEDDED {
};
+#define
TRANSLATION_OPCODE_LIST(V) \
+
V(BEGIN)
\
+
V(JS_FRAME)
\
+
V(CONSTRUCT_STUB_FRAME)
\
+
V(GETTER_STUB_FRAME)
\
+
V(SETTER_STUB_FRAME)
\
+
V(ARGUMENTS_ADAPTOR_FRAME)
\
+
V(COMPILED_STUB_FRAME)
\
+
V(DUPLICATED_OBJECT)
\
+
V(ARGUMENTS_OBJECT)
\
+
V(CAPTURED_OBJECT)
\
+
V(REGISTER)
\
+
V(INT32_REGISTER)
\
+
V(UINT32_REGISTER)
\
+
V(DOUBLE_REGISTER)
\
+
V(STACK_SLOT)
\
+
V(INT32_STACK_SLOT)
\
+
V(UINT32_STACK_SLOT)
\
+
V(DOUBLE_STACK_SLOT)
\
+ V(LITERAL)
+
+
class Translation BASE_EMBEDDED {
public:
+#define DECLARE_TRANSLATION_OPCODE_ENUM(item) item,
enum Opcode {
- BEGIN,
- JS_FRAME,
- CONSTRUCT_STUB_FRAME,
- GETTER_STUB_FRAME,
- SETTER_STUB_FRAME,
- ARGUMENTS_ADAPTOR_FRAME,
- COMPILED_STUB_FRAME,
- DUPLICATED_OBJECT,
- ARGUMENTS_OBJECT,
- CAPTURED_OBJECT,
- REGISTER,
- INT32_REGISTER,
- UINT32_REGISTER,
- DOUBLE_REGISTER,
- STACK_SLOT,
- INT32_STACK_SLOT,
- UINT32_STACK_SLOT,
- DOUBLE_STACK_SLOT,
- LITERAL
+ TRANSLATION_OPCODE_LIST(DECLARE_TRANSLATION_OPCODE_ENUM)
+ LAST = LITERAL
};
+#undef DECLARE_TRANSLATION_OPCODE_ENUM
Translation(TranslationBuffer* buffer, int frame_count, int
jsframe_count,
Zone* zone)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
