This is LGTM for now, but please consider implementing the deferred code
smi-recovery mechanism discussed below.
https://codereview.chromium.org/24754002/diff/4001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/24754002/diff/4001/src/x64/macro-assembler-x64.cc#newcode1545
src/x64/macro-assembler-x64.cc:1545: subq(dst, kScratchRegister);
This is probably OK for now, but probably slightly more efficient would
be for the MacroAssembler to keep a list of deferred code (e.g. smi
overflow recovery) items that output at the very end of the generated
code. That allows the code here to be straight-line, only branching away
to a code island in the very unlikely overflow case.
https://codereview.chromium.org/24754002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
